fix: remove ilpp for network variable [MTT-3438]#1976
Merged
Conversation
# Conflicts: # com.unity.netcode.gameobjects/Editor/CodeGen/com.unity.netcode.editor.codegen.asmdef # testproject/Assets/Tests/Runtime/testproject.runtimetests.asmdef
…atible with extension methods - Added xmldocs - Added tests
# Conflicts: # com.unity.netcode.gameobjects/Editor/CodeGen/INetworkSerializableILPP.cs # com.unity.netcode.gameobjects/Runtime/NetworkVariable/NetworkVariableHelper.cs # com.unity.netcode.gameobjects/Runtime/NetworkVariable/NetworkVariableSerialization.cs # com.unity.netcode.gameobjects/Runtime/Serialization/BufferSerializer.cs # com.unity.netcode.gameobjects/Runtime/Serialization/FastBufferReader.cs # com.unity.netcode.gameobjects/Runtime/Serialization/FastBufferWriter.cs
ShadauxCat
commented
May 18, 2022
| - Fixed issues when multiple `ConnectionApprovalCallback`s were registered (#1972) | ||
| - Fixed endless dialog boxes when adding a NetworkBehaviour to a NetworkManager or vice-versa (#1947) | ||
| - `FixedString` types can now be used in NetworkVariables and RPCs again without requiring a `ForceNetworkSerializeByMemcpy<>` wrapper (#1961) | ||
| - `FixedString`, `Vector2Int`, and `Vector3Int` types can now be used in NetworkVariables and RPCs again without requiring a `ForceNetworkSerializeByMemcpy<>` wrapper (#1961) |
Collaborator
Author
There was a problem hiding this comment.
Mentioning Vector2Int and Vector3Int was supposed to be part of my last PR but I forgot to push it after I committed it so it ended up in this branch by accident, but also needs to be there... I'll move it into a separate PR if desired but it seems so small as to not warrant it, maybe?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were cases where generic types were causing ILPP to perform incorrectly or crash at compile-time. This removes the offending ILPP code entirely - a couple of the generic cases were already addressed and another was found, so confidence that the ILPP wouldn't turn into an infinite series of such fixes was low. Moving to a runtime approach also reduces compile times since we have less ILPP code running.
Changelog
Testing and Documentation